Skip to content

Commit 38af7ba

Browse files
authored
Merge pull request #1218 from betatim/add-namespace-report
[MRG] Always provide k8s namespace report, limit step timeout
2 parents a36348e + 29e29a5 commit 38af7ba

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

.github/workflows/test.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -112,6 +112,7 @@ jobs:
112112
--set config.BinderHub.hub_url_local=http://proxy-public \
113113
--set config.BinderHub.access_token=$GITHUB_ACCESS_TOKEN
114114
- name: Wait for JupyterHub to be ready
115+
timeout-minutes: 10
115116
run: |
116117
# Wait for JupyterHub to be ready
117118
set -e
@@ -130,8 +131,9 @@ jobs:
130131
echo
131132
echo "curl http://localhost:30902/hub/api/" should print the JupyterHub version
132133
curl http://localhost:30902/hub/api/
133-
- name: Wait for binderhub to be ready
134+
- name: Wait for BinderHub to be ready
134135
if: matrix.test == 'helm'
136+
timeout-minutes: 10
135137
run: |
136138
# Wait for BinderHub to be ready
137139
set -e
@@ -154,13 +156,11 @@ jobs:
154156
export BINDER_URL=http://localhost:30901
155157
pytest -m "remote" -vx --cov binderhub
156158
- name: Kubernetes namespace report
157-
if: ${{ failure() }}
159+
if: ${{ always() }}
158160
run: |
159161
# Display debugging information
160162
. ci/common
161163
full_namespace_report
162164
- name: Upload coverage stats
163165
uses: codecov/codecov-action@v1
164-
# https://help.github.com/en/actions/reference/context-and-expression-syntax-for-github-actions
165-
# Upload regardless of whether tests pass or fail
166-
if: ${{ !cancelled() }}
166+
if: ${{ always() }}

0 commit comments

Comments
 (0)