Skip to content

Commit 3b19743

Browse files
authored
Merge pull request #1555 from consideRatio/pr/modern-chartpress
helm chart: use modern chartpress and baseVersion 1.0.0-0.dev
2 parents d8f0e3b + 951750e commit 3b19743

File tree

5 files changed

+5
-6
lines changed

5 files changed

+5
-6
lines changed

.github/workflows/publish.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ jobs:
5353
run: |
5454
. ./ci/common
5555
setup_helm v3.5.4
56-
pip install --no-cache-dir chartpress>=1.2 pyyaml
56+
pip install --no-cache-dir chartpress>=2.1 pyyaml
5757
5858
- name: Setup push rights to jupyterhub/helm-chart
5959
# This was setup by...

dev-requirements.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
beautifulsoup4
2-
chartpress>=1.2
2+
chartpress>=2.1
33
click
44
codecov
55
html5lib

helm-chart/binderhub/Chart.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# Chart.yaml v2 reference: https://helm.sh/docs/topics/charts/#the-chartyaml-file
22
apiVersion: v2
33
name: binderhub
4-
version: 0.2.0-set.by.chartpress
4+
version: 0.0.1-set.by.chartpress
55
dependencies:
66
# Source code: https://github.com/jupyterhub/zero-to-jupyterhub-k8s
77
# Latest version: https://github.com/jupyterhub/zero-to-jupyterhub-k8s/tags

helm-chart/binderhub/values.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ nodeSelector: {}
1717

1818
image:
1919
name: jupyterhub/k8s-binderhub
20-
tag: "local"
20+
tag: "set-by-chartpress"
2121

2222
# registry here is only used to create docker config.json
2323
registry:

helm-chart/chartpress.yaml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,12 +5,11 @@
55
# helm-chart folder.
66
charts:
77
- name: binderhub
8+
baseVersion: 1.0.0-0.dev
89
imagePrefix: jupyterhub/k8s-
910
repo:
1011
git: jupyterhub/helm-chart
1112
published: https://jupyterhub.github.io/helm-chart
12-
resetTag: local
13-
resetVersion: 0.2.0
1413
images:
1514
binderhub:
1615
# We will not use the default build contextPath, and must therefore

0 commit comments

Comments
 (0)