Skip to content

Commit 3d0bbb5

Browse files
committed
adding a path suffix so binderhub ingress works correctly with GCP load balancers. Similar to jupyterhub/zero-to-jupyterhub-k8s@c2bd799
1 parent 8debab3 commit 3d0bbb5

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

helm-chart/binderhub/templates/ingress.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ spec:
2222
- host: {{ . }}
2323
http:
2424
paths:
25-
- path: /
25+
- path: /{{ $.Values.ingress.pathSuffix }}
2626
backend:
2727
serviceName: binder
2828
servicePort: 80

helm-chart/binderhub/values.yaml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -203,6 +203,9 @@ ingress:
203203
annotations: {}
204204
# kubernetes.io/ingress.class: nginx
205205
# kubernetes.io/tls-acme: "true"
206+
pathSuffix: ''
207+
# Suffix added to Ingress's routing path pattern.
208+
# Specify `*` if your ingress matches path by glob pattern.
206209
tls: []
207210
# Secrets must be manually created in the namespace.
208211
# - secretName: chart-example-tls

0 commit comments

Comments
 (0)