Rename ProgressEvent.BuildStatus.COMPLETED to BUILT

Author: manics

binderhub/build.py

@@ -47,7 +47,7 @@ class BuildStatus(Enum):
 
         PENDING = "pending"
         RUNNING = "running"
-        COMPLETED = "built"
+        BUILT = "built"
         FAILED = "failed"
         UNKNOWN = "unknown"
 

binderhub/builder.py

@@ -513,7 +513,7 @@ def _check_result(future):
                     if progress.payload == ProgressEvent.BuildStatus.PENDING:
                         # nothing to do, just waiting
                         continue
-                    elif progress.payload == ProgressEvent.BuildStatus.COMPLETED:
+                    elif progress.payload == ProgressEvent.BuildStatus.BUILT:
                         event = {
                             "phase": phase,
                             "message": "Built image, launching...\n",
@@ -526,7 +526,7 @@ def _check_result(future):
                             log_future = pool.submit(build.stream_logs)
                             log_future.add_done_callback(_check_result)
                         continue
-                    elif progress.payload == ProgressEvent.BuildStatus.COMPLETED:
+                    elif progress.payload == ProgressEvent.BuildStatus.BUILT:
                         # Do nothing, is ok!
                         continue
                     elif progress.payload == ProgressEvent.BuildStatus.FAILED:

binderhub/tests/test_build.py

@@ -259,7 +259,7 @@ async def test_local_repo2docker_build():
         event = await q.get(10)
         if (
             event.kind == ProgressEvent.Kind.BUILD_STATUS_CHANGE
-            and event.payload == ProgressEvent.BuildStatus.COMPLETED
+            and event.payload == ProgressEvent.BuildStatus.BUILT
         ):
             break
         events.append(event)