Merge pull request #1807 from manics/eslint-all

Enable and fix eslint for all packages

Author: yuvipanda

.eslintrc.js

@@ -2,9 +2,12 @@ module.exports = {
   env: {
     browser: true,
     jquery: true,
+    node: true,
+    es6: true,
     "jest/globals": true,
   },
   extends: ["eslint:recommended"],
+  ignorePatterns: ["**/dist"],
   parser: "@babel/eslint-parser",
   plugins: ["jest"],
   rules: {},

examples/appendix/static/custom.js

@@ -1,3 +1,4 @@
+// eslint-disable-next-line no-unused-vars
 function copy_link_into_clipboard(b) {
   var $temp = $("<input>");
   $(b).parent().append($temp);

js/packages/binderhub-client/lib/index.js

@@ -70,7 +70,7 @@ export class BinderRepository {
     this.eventSource = new EventSource(this.buildUrl);
     return new EventIterator((queue) => {
       this.eventIteratorQueue = queue;
-      this.eventSource.onerror = (err) => {
+      this.eventSource.onerror = () => {
         queue.push({
           phase: "failed",
           message: "Failed to connect to event stream\n",

package.json

@@ -32,7 +32,7 @@
   "scripts": {
     "webpack": "webpack",
     "webpack:watch": "webpack --watch",
-    "lint": "eslint binderhub/static/js",
+    "lint": "eslint .",
     "test": "jest"
   },
   "jest": {