Fix a few more typescript detected errors

yuvipanda · yuvipanda · commit 5661f17a79f0 · 2024-07-01T15:26:02.000-07:00
diff --git a/binderhub/static/js/components/FaviconUpdater.jsx b/binderhub/static/js/components/FaviconUpdater.jsx
@@ -3,8 +3,6 @@ import FailIcon from "../../images/favicon/fail.ico";
 import SuccessIcon from "../../images/favicon/success.ico";
 
 import { PROGRESS_STATES } from "./Progress.jsx";
-import { useEffect } from "react";
-import { updateFavicon } from "../src/favicon";
 
 /**
  * @typedef {object} FaviconUpdaterProps
diff --git a/binderhub/static/js/index.d.ts b/binderhub/static/js/index.d.ts
@@ -0,0 +1,2 @@
+// Tell typescript to be quiet about .ico files we use for favicons
+declare module "*.ico";
diff --git a/tsconfig.json b/tsconfig.json
@@ -1,7 +1,7 @@
 {
   "compilerOptions": {
     "allowJs": true,
-    "checkJs": false,
+    "checkJs": true,
     "noEmit": false,
     "allowSyntheticDefaultImports": true,
     "skipLibCheck": true,

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,2 @@`
	`1`	`+// Tell typescript to be quiet about .ico files we use for favicons`
	`2`	`+declare module "*.ico";`
Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,7 @@`
`1`	`1`	`{`
`2`	`2`	`"compilerOptions": {`
`3`	`3`	`"allowJs": true,`
`4`		`- "checkJs": false,`
	`4`	`+ "checkJs": true,`
`5`	`5`	`"noEmit": false,`
`6`	`6`	`"allowSyntheticDefaultImports": true,`
`7`	`7`	`"skipLibCheck": true,`