Skip to content

Commit 5872e32

Browse files
committed
add comments
1 parent 8f96e3f commit 5872e32

File tree

2 files changed

+5
-0
lines changed

2 files changed

+5
-0
lines changed

binderhub/repoproviders.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -227,6 +227,9 @@ def get_resolved_ref(self):
227227
async def get_resolved_spec(self):
228228
if not hasattr(self, 'record_id'):
229229
self.record_id = await self.get_resolved_ref()
230+
# zenodo registers a DOI which represents all versions.
231+
# and it always resolves to latest version
232+
# for that case, we have to replace it with record id
230233
resolved_spec = self.spec.split("zenodo")[0] + "zenodo." + self.record_id
231234
return resolved_spec
232235

binderhub/tests/test_repoproviders.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,8 @@ def test_spec_processing(spec, raw_user, raw_repo, raw_ref):
4343
'3242074',
4444
'https://doi.org/10.5281/zenodo.3242074',
4545
'zenodo-3242074'],
46+
# 10.5281/zenodo.705645 -> This DOI represents all versions, and will always resolve to the latest one
47+
# for now it is 3242074
4648
['10.5281/zenodo.3242073',
4749
'10.5281/zenodo.3242074',
4850
'3242074',

0 commit comments

Comments
 (0)