Skip to content

Commit 5969487

Browse files
committed
Set deprecated params on new *BuildExecutor
1 parent 5980df8 commit 5969487

File tree

1 file changed

+21
-0
lines changed

1 file changed

+21
-0
lines changed

binderhub/app.py

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -730,6 +730,27 @@ def _template_path_default(self):
730730
help="Origin to use when emitting events. Defaults to hostname of request when empty",
731731
)
732732

733+
_build_config_deprecated_map = {
734+
"appendix": ("BuildExecutor", "appendix"),
735+
"push_secret": ("BuildExecutor", "push_secret"),
736+
"build_memory_limit": ("BuildExecutor", "memory_limit"),
737+
"sticky_builds": ("KubernetesBuildExecutor", "sticky_builds"),
738+
"log_tail_lines": ("KubernetesBuildExecutor", "log_tail_lines"),
739+
"build_memory_request": ("KubernetesBuildExecutor", "memory_request"),
740+
"build_docker_host": ("KubernetesBuildExecutor", "docker_host"),
741+
"build_namespace": ("KubernetesBuildExecutor", "namespace"),
742+
"build_image": ("KubernetesBuildExecutor", "build_image"),
743+
"build_node_selector": ("KubernetesBuildExecutor", "node_selector"),
744+
}
745+
746+
@observe(*_build_config_deprecated_map)
747+
def _build_config_deprecated(self, change):
748+
dest_cls, dest_name = self._build_config_deprecated_map[change.name]
749+
self.log.warning(
750+
"BinderHub.%s is deprecated, use %s.%s", change.name, dest_cls, dest_name
751+
)
752+
self.config.get(dest_cls)[dest_name] = change.new
753+
733754
@staticmethod
734755
def add_url_prefix(prefix, handlers):
735756
"""add a url prefix to handlers"""

0 commit comments

Comments
 (0)