Skip to content

Commit 6903302

Browse files
committed
Add breaking changes to CHANGES.md
1 parent 7fad682 commit 6903302

File tree

1 file changed

+22
-0
lines changed

1 file changed

+22
-0
lines changed

CHANGES.md

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,28 @@ If you were previously disabling the image cleaner replace:
3333

3434
- `imageCleaner.host.enabled: false` ➡️ `imageCleaner.enabled: false`
3535

36+
### `binderhub.build.Build` class replaced by `binderhub.build.KubernetesBuildExecutor`
37+
38+
The `binderhub.build.Build` class is replaced by the Traitlets based `binderhub.build.KubernetesBuildExecutor` class
39+
[#1518](https://github.com/jupyterhub/binderhub/pull/1518),
40+
[#1521](https://github.com/jupyterhub/binderhub/pull/1521).
41+
42+
The following build configuration properties should be set using Traitlets in the BinderHub configuration:
43+
44+
- `c.BinderHub.appendix` ➡️ `c.BuildExecutor.appendix`
45+
- `c.BinderHub.sticky_builds` ➡️ `c.KubernetesBuildExecutor.sticky_builds`
46+
- `c.BinderHub.log_tail_lines` ➡️ `c.KubernetesBuildExecutor.log_tail_lines`
47+
- `c.BinderHub.push_secret` ➡️ `c.BuildExecutor.push_secret`
48+
- `c.BinderHub.build_memory_request` ➡️ `c.KubernetesBuildExecutor.memory_request`
49+
- `c.BinderHub.build_memory_limit` ➡️ `c.BuildExecutor.memory_limit`
50+
- `c.BinderHub.build_docker_host` ➡️ `c.KubernetesBuildExecutor.docker_host`
51+
- `c.BinderHub.build_namespace` ➡️ `c.KubernetesBuildExecutor.namespace`
52+
- `c.BinderHub.build_image` ➡️ `c.KubernetesBuildExecutor.build_image`
53+
- `c.BinderHub.build_node_selector` ➡️ `c.KubernetesBuildExecutor.node_selector`
54+
55+
If you have subclassed `binderhub.build.Build` you must update your subclass (including `__init__()` if defined) to inherit from `binderhub.build.KubernetesBuildExecutor`.
56+
The behaviour of the class is otherwise unchanged.
57+
3658
# 0.2.0
3759

3860
# master@{2019-07-01}...master@{2019-10-01}

0 commit comments

Comments
 (0)