Skip to content

Commit 81660eb

Browse files
authored
Merge pull request #1252 from betatim/fix-test_build-hang
[MRG] In unit tests close client connection once 'ready' message arrives
2 parents 60e9f38 + 88368da commit 81660eb

File tree

1 file changed

+7
-0
lines changed

1 file changed

+7
-0
lines changed

binderhub/tests/test_build.py

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,13 @@ async def test_build(app, needs_build, needs_launch, always_build, slug, pytestc
5252
events.append(event)
5353
assert 'message' in event
5454
sys.stdout.write(event['message'])
55+
# this is the signal that everything is ready, pod is launched
56+
# and server is up inside the pod. Break out of the loop now
57+
# because BinderHub keeps the connection open for many seconds
58+
# after to avoid "reconnects" from slow clients
59+
if event.get('phase') == 'ready':
60+
r.close()
61+
break
5562

5663
final = events[-1]
5764
assert 'phase' in final

0 commit comments

Comments
 (0)