Skip to content

Commit 8c7f69a

Browse files
committed
Set deprecated params on new *BuildExecutor
1 parent fff83b2 commit 8c7f69a

File tree

1 file changed

+21
-0
lines changed

1 file changed

+21
-0
lines changed

binderhub/app.py

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -751,6 +751,27 @@ def _template_path_default(self):
751751
help="Origin to use when emitting events. Defaults to hostname of request when empty",
752752
)
753753

754+
_build_config_deprecated_map = {
755+
"appendix": ("BuildExecutor", "appendix"),
756+
"push_secret": ("BuildExecutor", "push_secret"),
757+
"build_memory_limit": ("BuildExecutor", "memory_limit"),
758+
"sticky_builds": ("KubernetesBuildExecutor", "sticky_builds"),
759+
"log_tail_lines": ("KubernetesBuildExecutor", "log_tail_lines"),
760+
"build_memory_request": ("KubernetesBuildExecutor", "memory_request"),
761+
"build_docker_host": ("KubernetesBuildExecutor", "docker_host"),
762+
"build_namespace": ("KubernetesBuildExecutor", "namespace"),
763+
"build_image": ("KubernetesBuildExecutor", "build_image"),
764+
"build_node_selector": ("KubernetesBuildExecutor", "node_selector"),
765+
}
766+
767+
@observe(*_build_config_deprecated_map)
768+
def _build_config_deprecated(self, change):
769+
dest_cls, dest_name = self._build_config_deprecated_map[change.name]
770+
self.log.warning(
771+
"BinderHub.%s is deprecated, use %s.%s", change.name, dest_cls, dest_name
772+
)
773+
self.config.get(dest_cls)[dest_name] = change.new
774+
754775
@staticmethod
755776
def add_url_prefix(prefix, handlers):
756777
"""add a url prefix to handlers"""

0 commit comments

Comments
 (0)