Merge pull request #1319 from g-braeunlich/target-repo-dir

Make build class configurable

Author: manics

binderhub/app.py

@@ -31,6 +31,7 @@
     TraitError,
     Unicode,
     Union,
+    Type,
     default,
     observe,
     validate,
@@ -249,6 +250,16 @@ def _valid_badge_base_url(self, proposal):
         config=True
     )
 
+    build_class = Type(
+        Build,
+        help="""
+        The class used to build repo2docker images.
+        
+        Must inherit from binderhub.build.Build
+        """,
+        config=True
+    )
+
     per_repo_quota = Integer(
         0,
         help="""
@@ -751,6 +762,7 @@ def initialize(self, *args, **kwargs):
                 "repo_providers": self.repo_providers,
                 "rate_limiter": RateLimiter(parent=self),
                 "use_registry": self.use_registry,
+                "build_class": self.build_class,
                 "registry": registry,
                 "traitlets_config": self.config,
                 "google_analytics_code": self.google_analytics_code,

binderhub/builder.py

@@ -22,7 +22,6 @@
 from prometheus_client import Counter, Histogram, Gauge
 
 from .base import BaseHandler
-from .build import Build, FakeBuild
 from .utils import KUBE_REQUEST_TIMEOUT
 
 # Separate buckets for builds and launches.
@@ -393,7 +392,7 @@ async def get(self, provider_prefix, _unescaped_spec):
         else:
             push_secret = None
 
-        BuildClass = FakeBuild if self.settings.get('fake_build') else Build
+        BuildClass = self.settings.get('build_class')
 
         appendix = self.settings['appendix'].format(
             binder_url=self.binder_launch_host + self.binder_request,

testing/local-binder-mocked-hub/binderhub_config.py

@@ -7,12 +7,13 @@
 # - JupyterHub: mocked
 
 from binderhub.repoproviders import FakeProvider
+from binderhub.build import FakeBuild
 
 c.BinderHub.debug = True
 c.BinderHub.use_registry = False
 c.BinderHub.builder_required = False
 c.BinderHub.repo_providers = {'gh': FakeProvider}
-c.BinderHub.tornado_settings.update({'fake_build': True})
+c.BinderHub.build_class = FakeBuild
 
 c.BinderHub.about_message = "<blink>Hello world.</blink>"
 c.BinderHub.banner_message = 'This is headline <a href="#">news.</a>'