Skip to content

Commit 92c63ba

Browse files
committed
Update error message for unresolved refs from GitHub repos
1 parent 87e78af commit 92c63ba

File tree

1 file changed

+19
-1
lines changed

1 file changed

+19
-1
lines changed

binderhub/builder.py

Lines changed: 19 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -250,8 +250,26 @@ async def get(self, provider_prefix, _unescaped_spec):
250250
except Exception as e:
251251
await self.fail("Error resolving ref for %s: %s" % (key, e))
252252
return
253+
253254
if ref is None:
254-
await self.fail("Could not resolve ref for %s. Double check your URL." % key)
255+
error_message = ["Could not resolve ref for %s. Double check your URL." % key]
256+
257+
split_key = key.split("/")
258+
repo_provider = split_key[0].split(":")[0]
259+
resolved_branch = split_key[-1]
260+
261+
if repo_provider == "gh":
262+
error_message.append('GitHub recently changed default branches from "master" to "main".')
263+
264+
if resolved_branch == "master":
265+
error_message.append('Did you mean the "main" branch?')
266+
elif resolved_branch == "main":
267+
error_message.append('Did you mean the "master" branch?')
268+
269+
else:
270+
error_message.append("Is your repo public?")
271+
272+
await self.fail(" ".join(error_message))
255273
return
256274

257275
self.ref_url = await provider.get_resolved_ref_url()

0 commit comments

Comments
 (0)