Merge pull request #1301 from sgaist/add_lifecycle_support

Add container lifecycle hooks support to chart

Author: consideRatio

CONTRIBUTING.md

@@ -194,6 +194,13 @@ continue.
    (cd helm-chart && chartpress)
    ```
 
+1. Get the chart dependencies (for example JupyterHub)
+
+   ```bash
+   cd helm-chart/binderhub
+   helm dependency update
+   ```
+
 1. Validate, and then install the Helm chart defined in helm-chart/binderhub.
 
    This validation step is not making any modification to your Kubernetes
@@ -209,6 +216,8 @@ continue.
 
    If the validation succeeds, go ahead and upgrade/install the Helm chart.
 
+   Note that this will do the installation in the current namespace.
+
    ```bash
    helm upgrade --install binderhub-test helm-chart/binderhub \
       --values testing/k8s-binder-k8s-hub/binderhub-chart-config.yaml \

helm-chart/binderhub/templates/deployment.yaml

@@ -70,6 +70,10 @@ spec:
         args:
           - --config
           - /etc/binderhub/config/binderhub_config.py
+        {{- with .Values.lifecycle }}
+        lifecycle:
+          {{- . | toYaml | nindent 10 }}
+        {{- end }}
         volumeMounts:
           - mountPath: /etc/binderhub/config/
             name: config

helm-chart/binderhub/values.yaml

@@ -211,6 +211,7 @@ ingress:
     #     - chart-example.local
 
 initContainers: []
+lifecycle: {}
 extraVolumes: []
 extraVolumeMounts: []
 extraEnv: []