Skip to content

Commit a1e38d2

Browse files
authored
Add comment pointing to source of escaping logic
1 parent 9262456 commit a1e38d2

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

binderhub/launcher.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -161,6 +161,7 @@ async def launch(self, image, username, server_name='', repo_url='', extra_args=
161161
"""
162162
# TODO: validate the image argument?
163163

164+
# Matches the escaping that JupyterHub does https://github.com/jupyterhub/jupyterhub/blob/c00c3fa28703669b932eb84549654238ff8995dc/jupyterhub/user.py#L427
164165
escaped_username = quote(username, safe='@~')
165166
if self.create_user:
166167
# create a new user

0 commit comments

Comments
 (0)