Skip to content

Commit a6f2701

Browse files
authored
Merge pull request #1597 from manics/config-default-registry
Fix the default `use_registry` value
2 parents 03545a1 + c53d38d commit a6f2701

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

helm-chart/binderhub/values.yaml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,9 @@ service:
4040
loadBalancerIP:
4141

4242
config:
43-
BinderHub: {}
43+
BinderHub:
44+
# This must equal the default value of c.BinderHub.use_registry
45+
use_registry: true
4446

4547
extraConfig: {}
4648

testing/k8s-binder-k8s-hub/binderhub-chart-config-old.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ ingress:
2525
# against which we haven't. We currently only test this via
2626
# lint-and-validate-values.yaml that makes sure our rendered templates are
2727
# valid against a k8s api-server.
28-
imageBuilderType: "local"
28+
imageBuilderType: host
2929

3030
# NOTE: This is a mirror of the jupyterhub section in
3131
# jupyterhub-chart-config.yaml in testing/local-binder-k8s-hub, keep these

0 commit comments

Comments
 (0)