Skip to content

Commit b7eba93

Browse files
authored
Merge pull request #1339 from consideRatio/pr/install-dependencies-publish-system
ci: fix publish workflow by adding missing dependency
2 parents 8e3b5ac + bd4c4fd commit b7eba93

File tree

2 files changed

+6
-13
lines changed

2 files changed

+6
-13
lines changed

.github/workflows/publish.yml

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -30,13 +30,7 @@ jobs:
3030
run: |
3131
. ./ci/common
3232
setup_helm v3.5.4
33-
# FIXME: six is required by docker 5.0.0 but isn't explicitly required
34-
# any more.
35-
#
36-
# Upstream issue: https://github.com/docker/docker-py/issues/2807
37-
# Breaking commit: https://github.com/docker/docker-py/commit/c8fba210a222d4f7fde90da8f48db1e7faa637ec
38-
#
39-
pip install --no-cache-dir chartpress==1.0.* six
33+
pip install --no-cache-dir chartpress>=1.2 pyyaml
4034
4135
- name: Setup push rights to jupyterhub/helm-chart
4236
# This was setup by...

dev-requirements.txt

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
beautifulsoup4
2-
chartpress==1.0.*
2+
chartpress>=1.2
33
click
44
codecov
55
html5lib
@@ -8,10 +8,9 @@ jupyterhub
88
pytest
99
pytest-asyncio
1010
pytest-cov
11+
# pyyaml is used by the scripts in tools/ and could absolutely be replaced by
12+
# using ruamel.yaml. ruamel.yaml is more powerful than pyyaml, and that is
13+
# relevant when writing YAML files back after having loaded them from disk.
14+
pyyaml
1115
requests
1216
ruamel.yaml>=0.15
13-
# FIXME: six is required by docker 5.0.0 but isn't explicitly required any more.
14-
# Upstream issue: https://github.com/docker/docker-py/issues/2807
15-
# Breaking commit: https://github.com/docker/docker-py/commit/c8fba210a222d4f7fde90da8f48db1e7faa637ec
16-
#
17-
six

0 commit comments

Comments
 (0)