Skip to content

Commit d1e4683

Browse files
Ensure config_dict not empty
1 parent 1384b05 commit d1e4683

File tree

1 file changed

+23
-16
lines changed

1 file changed

+23
-16
lines changed

binderhub/static/js/index.js

Lines changed: 23 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ import {fit} from './vendor/xterm/addons/fit';
3131

3232
var BASE_URL = $('#base-url').data().url;
3333
var BADGE_BASE_URL = $('#badge-base-url').data().url;
34-
var config_dict = {"gh": "caca"};
34+
var config_dict = {};
3535

3636
function update_favicon(path) {
3737
var link = document.querySelector("link[rel*='icon']") || document.createElement('link');
@@ -70,18 +70,29 @@ function loadConfig(callback) {
7070
req.send(null);
7171
}
7272

73+
function setLabels() {
74+
var provider = $("#provider_prefix").val();
75+
var text = config_dict[provider]["text"];
76+
var tag_text = config_dict[provider]["tag_text"];
77+
var ref_prop_disabled = config_dict[provider]["ref_prop_disabled"];
78+
var label_prop_disabled = config_dict[provider]["label_prop_disabled"];
79+
var placeholder = "HEAD";
80+
81+
$("#ref").attr('placeholder', placeholder).prop("disabled", ref_prop_disabled);
82+
$("label[for=ref]").text(tag_text).prop("disabled", label_prop_disabled);
83+
$("#repository").attr('placeholder', text);
84+
$("label[for=repository]").text(text);
85+
}
86+
7387
function updateRepoText() {
74-
var provider = $("#provider_prefix").val();
75-
var text = config_dict[provider]["text"]
76-
var tag_text = config_dict[provider]["tag_text"]
77-
var ref_prop_disabled = config_dict[provider]["ref_prop_disabled"]
78-
var label_prop_disabled = config_dict[provider]["label_prop_disabled"]
79-
var placeholder = "HEAD";
80-
81-
$("#ref").attr('placeholder', placeholder).prop("disabled", ref_prop_disabled);
82-
$("label[for=ref]").text(tag_text).prop("disabled", label_prop_disabled);
83-
$("#repository").attr('placeholder', text);
84-
$("label[for=repository]").text(text);
88+
if (Object.keys(config_dict).length === 0){
89+
loadConfig(function(res) {
90+
config_dict = JSON.parse(res);
91+
setLabels();
92+
});
93+
} else {
94+
setLabels();
95+
}
8596
}
8697

8798
function getBuildFormValues() {
@@ -251,10 +262,6 @@ function indexMain() {
251262
// setup badge dropdown and default values.
252263
updateUrls();
253264

254-
loadConfig(function(res) {
255-
config_dict = JSON.parse(res);
256-
});
257-
258265
$("#provider_prefix_sel li").click(function(event){
259266
event.preventDefault();
260267

0 commit comments

Comments
 (0)