Skip to content

Commit ee4876b

Browse files
authored
Merge pull request #1601 from manics/pink-extra-args
pink.daemonset.extraArgs[]
2 parents 7a7da20 + bf560a0 commit ee4876b

File tree

2 files changed

+8
-1
lines changed

2 files changed

+8
-1
lines changed

helm-chart/binderhub/schema.yaml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -391,7 +391,7 @@ properties:
391391
extraArgs:
392392
type: array
393393
description: |
394-
TODO
394+
Extra command line arguments for the Docker daemon
395395
lifecycle: &lifecycle-spec
396396
type: object
397397
additionalProperties: false
@@ -437,6 +437,10 @@ properties:
437437
additionalProperties: false
438438
properties:
439439
image: *image-spec
440+
extraArgs:
441+
type: array
442+
description: |
443+
Extra command line arguments for the Podman service, e.g. `[--log-level=debug]`
440444
lifecycle: *lifecycle-spec
441445
extraVolumes: *extraVolumes-spec
442446
extraVolumeMounts: *extraVolumeMounts-spec

helm-chart/binderhub/templates/container-builder/daemonset.yaml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,9 @@ spec:
7474
- service
7575
- --time=0
7676
- unix://{{ $builder.hostSocketDir }}/podman.sock
77+
{{- with $daemonset.extraArgs }}
78+
{{- . | toYaml | nindent 12 }}
79+
{{- end }}
7780
securityContext:
7881
privileged: true
7982
runAsUser: 0

0 commit comments

Comments
 (0)