Skip to content

Commit f08d55f

Browse files
authored
Apply suggestions from code review
1 parent ef98667 commit f08d55f

File tree

3 files changed

+3
-6
lines changed

3 files changed

+3
-6
lines changed

helm-chart/binderhub/templates/configmap.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,4 +21,4 @@ data:
2121
2222
{{- /* Glob files to allow them to be mounted by the binderhub pod */ -}}
2323
{{- /* key=filename: value=content */ -}}
24-
{{- (.Files.Glob "files/*").AsConfig | nindent 2 }}
24+
{{- (.Files.Glob "files/*").AsConfig | nindent 2 }}

helm-chart/binderhub/templates/deployment.yaml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -64,10 +64,6 @@ spec:
6464
containers:
6565
- name: binder
6666
image: {{ .Values.image.name }}:{{ .Values.image.tag }}
67-
command:
68-
- python3
69-
- -m
70-
- binderhub
7167
args:
7268
- --config
7369
- /etc/binderhub/config/binderhub_config.py

helm-chart/images/binderhub/Dockerfile

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ RUN pip install --no-cache-dir \
3838
*.whl \
3939
-r requirements.txt
4040

41-
CMD ["python3", "-m", "binderhub", "--config", "/etc/binderhub/config/binderhub_config.py"]
41+
ENTRYPOINT ["python3", "-m", "binderhub"]
42+
CMD ["--config", "/etc/binderhub/config/binderhub_config.py"]
4243
ENV PYTHONUNBUFFERED=1
4344
EXPOSE 8585

0 commit comments

Comments
 (0)