Skip to content

Commit ffcf636

Browse files
committed
binderhub image: bump to google-cloud-logging v3 (from v1)
1 parent 1ec0548 commit ffcf636

File tree

1 file changed

+12
-6
lines changed

1 file changed

+12
-6
lines changed

helm-chart/images/binderhub/requirements.in

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,18 @@
1-
# FIXME: google-cloud-logging was pinned to avoid introducing a potentially
2-
# breaking change as major version 2 was recently released. See:
3-
# https://github.com/googleapis/python-logging/blob/master/UPGRADING.md
4-
google-cloud-logging==1.*
1+
# google-cloud-logging is an optional dependency used by mybinder.org-deploy at
2+
# https://github.com/jupyterhub/mybinder.org-deploy/blob/e47021fe/mybinder/values.yaml#L193-L216.
3+
#
4+
# We pin it to avoid introducing a potentially breaking change as major versions
5+
# are released. See:
6+
# https://github.com/googleapis/python-logging/blob/master/UPGRADING.md
7+
#
8+
google-cloud-logging==3.*
59

6-
# jupyterhub is pinned to match the JupyterHub Helm chart's
7-
# version of jupyterhub
10+
# jupyterhub's major version should be matched with the JupyterHub Helm chart's
11+
# used version of JupyterHub.
12+
#
813
jupyterhub==1.5.*
914

15+
# https://github.com/kubernetes-client/python
1016
kubernetes==9.*
1117

1218
# binderhub's dependencies

0 commit comments

Comments
 (0)