Skip to content

Commit 655c1f7

Browse files
committed
switch to http-proxy-3
requires node 20, a major bump since no LTS has it
1 parent 176c1e4 commit 655c1f7

File tree

5 files changed

+155
-375
lines changed

5 files changed

+155
-375
lines changed

.github/workflows/test.yml

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ on:
2424
jobs:
2525
# Audit dependencies for known vulnerabilities
2626
audit-dependencies:
27-
runs-on: ubuntu-22.04
27+
runs-on: ubuntu-24.04
2828
steps:
2929
- uses: actions/checkout@v4
3030
- uses: actions/setup-node@v4
@@ -50,21 +50,19 @@ jobs:
5050
npm audit --production --audit-level=moderate
5151
5252
test:
53-
runs-on: ubuntu-20.04
53+
runs-on: ubuntu-24.04
5454
strategy:
5555
fail-fast: false # Do not cancel all jobs if one fails
5656
matrix:
5757
# IMPORTANT: Make sure to update package.json's engines.node field to
5858
# always require at least the oldest version, as well as our
5959
# README.md file under the install section.
6060
node_version:
61-
# Removing node 10 is dropping support for ubuntu 20.04 LTS
62-
- "10"
63-
- "12"
64-
- "14"
65-
- "16"
66-
- "18"
61+
# ubuntu 24.04 LTS has node 18,
62+
# so we currently require non-distro nodejs ~everywhere
63+
# (e.g. nodesource, containers)
6764
- "20"
65+
- "22"
6866
- current
6967

7068
steps:

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ functionality to [JupyterHub] deployments.
3636

3737
## Install
3838

39-
Prerequisite: [Node.js](https://nodejs.org/en/download/)10
39+
Prerequisite: [Node.js](https://nodejs.org/en/download/)20
4040

4141
If you're installing `configurable-http-proxy` in Linux, you can follow [the instruction of nodesource](https://github.com/nodesource/distributions#installation-instructions) to install arbitrary version of Node.js.
4242

lib/configproxy.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ var http = require("http"),
1313
fs = require("fs"),
1414
path = require("path"),
1515
EventEmitter = require("events").EventEmitter,
16-
httpProxy = require("http-proxy-node16"),
16+
httpProxy = require("http-proxy-3"),
1717
winston = require("winston"),
1818
util = require("util"),
1919
URL = require("url"),

0 commit comments

Comments
 (0)