Fail early on missing websockify executable

consideRatio · consideRatio · commit c12c16c956ee · 2024-03-30T18:23:58.000+01:00
diff --git a/jupyter_remote_desktop_proxy/setup_websockify.py b/jupyter_remote_desktop_proxy/setup_websockify.py
@@ -12,6 +12,8 @@ def setup_websockify():
         raise RuntimeError(
             "vncserver executable not found, please install a VNC server"
         )
+    if not which('websockify'):
+        raise RuntimeError("websockify executable not found, please install websockify")
 
     # TurboVNC and TigerVNC share the same origin and both use a Perl script
     # as the executable vncserver. We can determine if vncserver is TigerVNC

Original file line number	Diff line number	Diff line change
`@@ -12,6 +12,8 @@ def setup_websockify():`
`12`	`12`	`raise RuntimeError(`
`13`	`13`	`"vncserver executable not found, please install a VNC server"`
`14`	`14`	`)`
	`15`	`+ if not which('websockify'):`
	`16`	`+ raise RuntimeError("websockify executable not found, please install websockify")`
`15`	`17`
`16`	`18`	`# TurboVNC and TigerVNC share the same origin and both use a Perl script`
`17`	`19`	`# as the executable vncserver. We can determine if vncserver is TigerVNC`