Merge pull request #49 from minrk/main

consideRatio · web-flow · commit 8769ade97985 · 2022-12-20T10:31:54.000+01:00
fix type of request_timeout when $JUPYTERHUB_REQUEST_TIMEOUT is set
diff --git a/jupyterhub_idle_culler/__init__.py b/jupyterhub_idle_culler/__init__.py
@@ -97,7 +97,7 @@ async def cull_idle(
         # GET /users may be slow if there are thousands of users and we
         # don't do any server side filtering so default request timeouts
         # to 60 seconds rather than tornado's 20 second default.
-        "request_timeout": os.environ.get("JUPYTERHUB_REQUEST_TIMEOUT", 60)
+        "request_timeout": int(os.environ.get("JUPYTERHUB_REQUEST_TIMEOUT") or 60)
     }
     if ssl_enabled:
         ssl_context = make_ssl_context(

Original file line number	Diff line number	Diff line change
`@@ -97,7 +97,7 @@ async def cull_idle(`
`97`	`97`	`# GET /users may be slow if there are thousands of users and we`
`98`	`98`	`# don't do any server side filtering so default request timeouts`
`99`	`99`	`# to 60 seconds rather than tornado's 20 second default.`
`100`		`- "request_timeout": os.environ.get("JUPYTERHUB_REQUEST_TIMEOUT", 60)`
	`100`	`+ "request_timeout": int(os.environ.get("JUPYTERHUB_REQUEST_TIMEOUT") or 60)`
`101`	`101`	`}`
`102`	`102`	`if ssl_enabled:`
`103`	`103`	`ssl_context = make_ssl_context(`