Skip to content

Commit b01ea1d

Browse files
authored
Merge pull request #2340 from minrk/validate-experimental
syntax fix: continue-on-error is not under strategy
2 parents a7f7b40 + d7f2220 commit b01ea1d

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

.github/workflows/cd.yml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,11 +64,13 @@ jobs:
6464
((github.event_name == 'push') && (github.ref == 'refs/heads/master')) ||
6565
((github.event_name == 'push') && contains(github.ref, 'test-this-pr'))
6666
runs-on: ubuntu-20.04
67+
# https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#example-preventing-a-specific-failing-matrix-job-from-failing-a-workflow-run
68+
continue-on-error: ${{ matrix.experimental }}
6769
strategy:
6870
fail-fast: false # Do not cancel all jobs if one fails
69-
# https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#example-preventing-a-specific-failing-matrix-job-from-failing-a-workflow-run
70-
continue-on-error: ${{ matrix.experimental }}
7171
matrix:
72+
experimental:
73+
- false
7274
include:
7375
# Now we have only one staging environment, but we have had two when
7476
# we transitioned from one k8s cluster to another.

0 commit comments

Comments
 (0)