-
Notifications
You must be signed in to change notification settings - Fork 78
Open
Description
BinderHub frontend UI migrated to vanilla HTML to React based app in jupyterhub/binderhub#1856. Because of this, the test
mybinder.org-deploy/tests/test_federation_redirect.py
Lines 13 to 16 in 6e2a0e2
| def test_proxy_page(helm_config, federation_url): | |
| r = requests.get(federation_url) | |
| r.raise_for_status() | |
| assert "How it works" in r.text |
The "simplest" solution is to replace assert to check for
<div id="root"></div>
from https://github.com/jupyterhub/binderhub/blob/65f807c12c61aed2179293d1bd0f72d117e92793/binderhub/templates/page.html#L24. In this simplest solution will don't need to run the JavaScript. We only check that the React based app has a HTML anchor.
Alternatively, the assert can be replaced with a solution powered by an automation library for browser testing like
Metadata
Metadata
Assignees
Labels
No labels