Skip to content

Commit 237375f

Browse files
committed
pytest >=7,<9
1 parent 6fe9ee6 commit 237375f

File tree

2 files changed

+13
-14
lines changed

2 files changed

+13
-14
lines changed

dev-requirements.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,6 @@ build
22
conda-lock
33
pre-commit
44
pytest-cov
5-
pytest>=4.6,<8
5+
pytest>=7,<9
66
pyyaml
77
requests_mock

tests/conftest.py

Lines changed: 12 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -33,11 +33,11 @@
3333
TESTS_DIR = os.path.abspath(os.path.dirname(__file__))
3434

3535

36-
def pytest_collect_file(parent, path):
37-
if path.basename == "verify":
38-
return LocalRepo.from_parent(parent, path=path)
39-
elif path.basename.endswith(".repos.yaml"):
40-
return RemoteRepoList.from_parent(parent, path=path)
36+
def pytest_collect_file(parent, file_path):
37+
if file_path.name == "verify":
38+
return LocalRepo.from_parent(parent, path=file_path)
39+
elif file_path.name.endswith(".repos.yaml"):
40+
return RemoteRepoList.from_parent(parent, path=file_path)
4141

4242

4343
def make_test_func(args, skip_build=False, extra_run_kwargs=None):
@@ -233,24 +233,23 @@ def collect(self):
233233
args = ["--appendix", 'RUN echo "appendix" > /tmp/appendix']
234234
# If there's an extra-args.yaml file in a test dir, assume it contains
235235
# a yaml list with extra arguments to be passed to repo2docker
236-
extra_args_path = os.path.join(self.path.dirname, "test-extra-args.yaml")
237-
if os.path.exists(extra_args_path):
238-
with open(extra_args_path) as f:
239-
extra_args = yaml.safe_load(f)
236+
extra_args_path = self.path.parent / "test-extra-args.yaml"
237+
if extra_args_path.exists():
238+
extra_args = yaml.safe_load(extra_args_path.read_text())
240239
args += extra_args
241240

242-
print(self.path.basename, self.path.dirname, str(self.path))
241+
print(self.path.name, self.path.parent, str(self.path))
243242
# re-use image name for multiple tests of the same image
244243
# so we don't run through the build twice
245-
rel_repo_dir = os.path.relpath(self.path.dirname, TESTS_DIR)
244+
rel_repo_dir = os.path.relpath(self.path.parent, TESTS_DIR)
246245
image_name = f"r2d-tests-{escapism.escape(rel_repo_dir, escape_char='-').lower()}-{int(time.time())}"
247246
args.append(f"--image-name={image_name}")
248-
args.append(self.path.dirname)
247+
args.append(str(self.path.parent))
249248
yield Repo2DockerTest.from_parent(self, name="build", args=args)
250249

251250
yield Repo2DockerTest.from_parent(
252251
self,
253-
name=self.path.basename,
252+
name=self.path.name,
254253
args=args + ["./verify"],
255254
skip_build=True,
256255
)

0 commit comments

Comments
 (0)