Skip to content

Commit 2b17eca

Browse files
authored
Merge pull request #6 from kardasbart/feat/new-base
Tests fix
2 parents aae6a71 + 0b9154a commit 2b17eca

File tree

4 files changed

+12
-12
lines changed

4 files changed

+12
-12
lines changed

Dockerfile

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
# syntax = docker/dockerfile:1.3
2-
ARG ALPINE_VERSION=3.16
2+
ARG ALPINE_VERSION=3.17
33
FROM alpine:${ALPINE_VERSION} AS builder
44

5-
RUN apk add --no-cache git python3 python3-dev py3-pip build-base
5+
RUN apk add --no-cache git python3 python3-dev py3-pip py3-setuptools build-base
66

77
# set pip's cache directory using this environment variable, and use
88
# ARG instead of ENV to ensure its only set when the image is built
@@ -21,7 +21,7 @@ RUN --mount=type=cache,target=${PIP_CACHE_DIR} \
2121
FROM alpine:${ALPINE_VERSION}
2222

2323
# install python, git, bash, mercurial
24-
RUN apk add --no-cache git git-lfs python3 py3-pip bash docker mercurial
24+
RUN apk add --no-cache git git-lfs python3 py3-pip py3-setuptools bash docker mercurial
2525

2626
# repeat ARG from above
2727
ARG PIP_CACHE_DIR=/tmp/pip-cache

repo2docker/buildpacks/r.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -343,10 +343,10 @@ def get_build_scripts(self):
343343
(
344344
"${NB_USER}",
345345
# Install a pinned version of devtools, IRKernel and shiny
346-
r"""
347-
EXPANDED_CRAN_MIRROR_URL="$(. /etc/os-release && echo {self.devtools_cran_mirror_url()} | envsubst)" && \
348-
R --quiet -e "install.packages(c('devtools', 'IRkernel', 'shiny'), repos='${{EXPANDED_CRAN_MIRROR_URL}}')" && \
349-
R --quiet -e "IRkernel::installspec(prefix='$NB_PYTHON_PREFIX')"
346+
rf"""
347+
export EXPANDED_CRAN_MIRROR_URL="$(. /etc/os-release && echo {cran_mirror_url} | envsubst)" && \
348+
R --quiet -e "install.packages(c('devtools', 'IRkernel', 'shiny'), repos=Sys.getenv(\"EXPANDED_CRAN_MIRROR_URL\"))" && \
349+
R --quiet -e "IRkernel::installspec(prefix=Sys.getenv(\"NB_PYTHON_PREFIX\"))"
350350
""",
351351
),
352352
]

repo2docker/contentproviders/git.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -45,10 +45,10 @@ def fetch(self, spec, output_dir, yield_output=False):
4545
self.log.error(
4646
f"Failed to check out ref {ref}", extra=dict(phase=R2dState.FAILED)
4747
)
48-
if ref == "master":
48+
if ref == "master" or ref == "main":
4949
msg = (
50-
"Failed to check out the 'master' branch. "
51-
"Maybe the default branch is not named 'master' "
50+
f"Failed to check out the '{ref}' branch. "
51+
f"Maybe the default branch is not named '{ref}' "
5252
"for this repository.\n\nTry not explicitly "
5353
"specifying `--ref`."
5454
)

tests/external/reproductions.repos.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,12 +12,12 @@
1212
# Test that a full remote/ref works
1313
- name: Binder Examples - Requirements
1414
url: https://github.com/binder-examples/requirements
15-
ref: origin/master
15+
ref: origin/main
1616
verify: python -c 'import matplotlib'
1717
# Test that ref is added to branch if not present
1818
- name: Binder Examples - Requirements
1919
url: https://github.com/binder-examples/requirements
20-
ref: master
20+
ref: main
2121
verify: python -c 'import matplotlib'
2222
# Test that tags work + ref is added to tag if not present
2323
- name: Binder Examples - Requirements

0 commit comments

Comments
 (0)