You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: CONTRIBUTING.md
+1-1Lines changed: 1 addition & 1 deletion
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -23,4 +23,4 @@ There are a few other pages to highlight:
23
23
Its a good place to understand _why_ the team have made the decisions that they have along the way!
24
24
* We absolutely encourage discussion around refactoring, updating or extending repo2docker, but please make sure that you've understood this page before opening an issue to discuss the change you'd like to propose.
25
25
*[Common developer tasks and how-tos](https://repo2docker.readthedocs.io/en/latest/contributing/tasks.html)
26
-
* Some notes on running tests, buildpack dependencies, creating a release, updating the changelog and keeping the pip files up to date.
26
+
* Some notes on running tests, buildpack dependencies, creating a release, and keeping the pip files up to date.
Copy file name to clipboardExpand all lines: docs/source/contributing/contributing.md
+2-2Lines changed: 2 additions & 2 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -61,10 +61,11 @@ This outlines the process for getting changes to the repo2docker project merged.
61
61
3. Make edits in [your fork](https://help.github.com/en/articles/fork-a-repo) of the [repo2docker repository](https://github.com/jupyterhub/repo2docker).
62
62
4. Make a [pull request](https://help.github.com/en/articles/about-pull-requests).
63
63
Read the [next section](#guidelines-to-getting-a-pull-request-merged) for guidelines for both reviewers and contributors on merging a PR.
64
-
5. Edit [the changelog](./../../changelog) by appending your feature / bug fix to the development version.
65
64
6. Wait for a community member to merge your changes.
66
65
Remember that **someone else must merge your pull request**.
67
66
That goes for new contributors and long term maintainers alike.
67
+
Because `master` is continuously deployed to mybinder.org it is essential
68
+
that `master` is always in a deployable state.
68
69
7. (optional) Deploy a new version of repo2docker to mybinder.org by [following these steps](http://mybinder-sre.readthedocs.io/en/latest/deployment/how.html)
69
70
70
71
## Guidelines to getting a Pull Request merged
@@ -84,7 +85,6 @@ These are not hard rules to be enforced by 🚓 but they are suggestions written
84
85
This makes it easier to find all changes since the last deployment `git log --merges --pretty=format:"%h %<(10,trunc)%an %<(15)%ar %s" <deployed-revision>..` and your PR easier to review.
85
86
***Make it clear when your PR is ready for review.**
86
87
Prefix the title of your pull request (PR) with `[MRG]` if the contribution is complete and should be subjected to a detailed review.
87
-
***Enter your changes into the [changelog](./../../changelog)** in `docs/source/changelog.rst`.
88
88
***Use commit messages to describe _why_ you are proposing the changes you are proposing.**
89
89
***Try to not rush changes** (the definition of rush depends on how big your changes are).
90
90
Remember that everyone in the repo2docker team is a volunteer and we can not (nor would we want to) control their time or interests.
0 commit comments