Skip to content

Commit 4540bf1

Browse files
committed
Remove conda buildpacks pin of r-irkernel to 1.2
If r-base is pinned, r-irkernel will resolve to a version that is compatible with it. But if we pin r-irkernel and not r-base, the opposite will happen and we will end up with an older version of r-base than is supported by r-irkernel's modern versions. I find debugging how versions resolve with conda is really tricky, so unless we have clear principles of what the pin should be and why, I strongly advocate we don't have it pinned here. In this case, having r-irkernel pinned to 1.2 caused us to get stuck at R version 4.1 instead of going to R 4.2 that is now available.
1 parent c981b3b commit 4540bf1

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

repo2docker/buildpacks/conda/__init__.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -362,7 +362,7 @@ def get_env_scripts(self):
362362
(
363363
"${NB_USER}",
364364
r"""
365-
${{MAMBA_EXE}} install -p {0} r-base{1} r-irkernel=1.2 r-devtools -y && \
365+
${{MAMBA_EXE}} install -p {0} r-base{1} r-irkernel r-devtools -y && \
366366
${{MAMBA_EXE}} clean --all -f -y && \
367367
${{MAMBA_EXE}} list -p {0}
368368
""".format(
@@ -385,7 +385,7 @@ def get_env_scripts(self):
385385
),
386386
(
387387
"${NB_USER}",
388-
# Install a pinned version of IRKernel and set it up for use!
388+
# Register the jupyter kernel
389389
r"""
390390
R --quiet -e "IRkernel::installspec(prefix='{0}')"
391391
""".format(

0 commit comments

Comments
 (0)