Skip to content

Commit 4a5b854

Browse files
authored
Merge pull request #1199 from consideRatio/pr/switch-to-build-package
Create wheels with the build package, stop calling setup.py directly
2 parents 84408ef + f3284bf commit 4a5b854

File tree

3 files changed

+14
-6
lines changed

3 files changed

+14
-6
lines changed

.github/workflows/release.yml

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -34,14 +34,22 @@ jobs:
3434
with:
3535
python-version: "3.9"
3636

37-
- name: Install dependencies
37+
- name: install build requirements
3838
run: |
39-
pip install -r dev-requirements.txt
39+
pip install build
4040
pip freeze
4141
42-
- name: Build distribution archives
42+
- name: build release
4343
run: |
44-
python setup.py sdist bdist_wheel
44+
python -m build --sdist --wheel .
45+
ls -l dist
46+
47+
# ref: https://github.com/actions/upload-artifact#readme
48+
- uses: actions/upload-artifact@v3
49+
with:
50+
name: repo2docker-${{ github.sha }}
51+
path: "dist/*"
52+
if-no-files-found: error
4553

4654
# This step is only run when a new tag is pushed
4755
# all previous steps always run in order to exercise them

.github/workflows/test.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ jobs:
116116
117117
- name: Install repo2docker
118118
run: |
119-
python setup.py bdist_wheel
119+
python -m build --wheel .
120120
pip install dist/*.whl
121121
122122
# add for mercurial tests

dev-requirements.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1+
build
12
codecov
23
conda-lock
34
pre-commit
45
pytest-cov
56
pytest>=4.6
67
pyyaml
78
requests_mock
8-
wheel

0 commit comments

Comments
 (0)