You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: docs/source/contributing/contributing.md
+3Lines changed: 3 additions & 0 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -63,6 +63,8 @@ This outlines the process for getting changes to the repo2docker project merged.
63
63
Read the [next section](#guidelines-to-getting-a-pull-request-merged) for guidelines for both reviewers and contributors on merging a PR.
64
64
5. Edit [the changelog](./../../changelog) by appending your feature / bug fix to the development version.
65
65
6. Wait for a community member to merge your changes.
66
+
Remember that **someone else must merge your pull request**.
67
+
That goes for new contributors and long term maintainers alike.
66
68
7. (optional) Deploy a new version of repo2docker to mybinder.org by [following these steps](http://mybinder-sre.readthedocs.io/en/latest/deployment/how.html)
67
69
68
70
## Guidelines to getting a Pull Request merged
@@ -87,6 +89,7 @@ These are not hard rules to be enforced by 🚓 but they are suggestions written
87
89
***Try to not rush changes** (the definition of rush depends on how big your changes are).
88
90
Remember that everyone in the repo2docker team is a volunteer and we can not (nor would we want to) control their time or interests.
89
91
Wait patiently for a reviewer to merge the PR.
92
+
(Remember that **someone else** must merge your PR, even if you have the admin rights to do so.)
0 commit comments