Skip to content

Commit 6344f39

Browse files
authored
Update contributing.md
1 parent 34cff4d commit 6344f39

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

docs/source/contributing/contributing.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,8 @@ This outlines the process for getting changes to the repo2docker project merged.
6363
Read the [next section](#guidelines-to-getting-a-pull-request-merged) for guidelines for both reviewers and contributors on merging a PR.
6464
5. Edit [the changelog](./../../changelog) by appending your feature / bug fix to the development version.
6565
6. Wait for a community member to merge your changes.
66+
Remember that **someone else must merge your pull request**.
67+
That goes for new contributors and long term maintainers alike.
6668
7. (optional) Deploy a new version of repo2docker to mybinder.org by [following these steps](http://mybinder-sre.readthedocs.io/en/latest/deployment/how.html)
6769

6870
## Guidelines to getting a Pull Request merged
@@ -87,6 +89,7 @@ These are not hard rules to be enforced by 🚓 but they are suggestions written
8789
* **Try to not rush changes** (the definition of rush depends on how big your changes are).
8890
Remember that everyone in the repo2docker team is a volunteer and we can not (nor would we want to) control their time or interests.
8991
Wait patiently for a reviewer to merge the PR.
92+
(Remember that **someone else** must merge your PR, even if you have the admin rights to do so.)
9093

9194
## Setting up for Local Development
9295

0 commit comments

Comments
 (0)