Merge pull request #371 from betatim/install-npm

[MRG] Fix up node install and add test

Author: choldgraf

.travis.yml

@@ -35,6 +35,7 @@ jobs:
         branch: master
 env:
   matrix:
+  - REPO_TYPE=base
   - REPO_TYPE=conda
   - REPO_TYPE=venv
   - REPO_TYPE=stencila

repo2docker/buildpacks/base.py

@@ -43,10 +43,10 @@
     ${NB_USER}
 WORKDIR ${HOME}
 
-RUN wget --quiet -O - https://deb.nodesource.com/gpgkey/nodesource.gpg.key |  apt-key add - \
-    DISTRO="$(lsb_release -s -c)" \
-    echo "deb https://deb.nodesource.com/$VERSION $DISTRO main" |  tee /etc/apt/sources.list.d/nodesource.list \
-    echo "deb-src https://deb.nodesource.com/$VERSION $DISTRO main" |  tee -a /etc/apt/sources.list.d/nodesource.list 
+RUN wget --quiet -O - https://deb.nodesource.com/gpgkey/nodesource.gpg.key |  apt-key add - && \
+    DISTRO="bionic" && \
+    echo "deb https://deb.nodesource.com/node_10.x $DISTRO main" >> /etc/apt/sources.list.d/nodesource.list && \
+    echo "deb-src https://deb.nodesource.com/node_10.x $DISTRO main" >> /etc/apt/sources.list.d/nodesource.list
 
 RUN apt-get update && \
     apt-get install --yes --no-install-recommends \
@@ -187,9 +187,7 @@ def get_base_packages(self):
         return {
             # Utils!
             "less",
-
             "nodejs",
-
             "unzip",
         }
 

tests/base/node10/README.md

@@ -0,0 +1 @@
+Test that node 10 is installed and runnable.

tests/base/node10/verify

@@ -0,0 +1,7 @@
+#!/bin/sh
+
+set -e
+which node
+node --version | grep v10
+which npm
+npm --version | grep 6.2