Can't just use '([^/]+)/' for the new figshare url

manics · manics · commit b032ad7c4b1c · 2021-01-08T23:46:57.000Z
This may break detection of non-code URLs
diff --git a/repo2docker/contentproviders/figshare.py b/repo2docker/contentproviders/figshare.py
@@ -39,7 +39,7 @@ def __init__(self):
             }
         ]
 
-    url_regex = re.compile(r"(.*)/articles/([^/]+)/([^/]+)/(\d+)(/)?(\d+)?")
+    url_regex = re.compile(r"(.*)/articles/(code/)?([^/]+)/(\d+)(/)?(\d+)?")
 
     def detect(self, doi, ref=None, extra_args=None):
         """Trigger this provider for things that resolve to a Figshare article"""

Original file line number	Diff line number	Diff line change
`@@ -39,7 +39,7 @@ def __init__(self):`
`39`	`39`	`}`
`40`	`40`	`]`
`41`	`41`
`42`		`- url_regex = re.compile(r"(.*)/articles/([^/]+)/([^/]+)/(\d+)(/)?(\d+)?")`
	`42`	`+ url_regex = re.compile(r"(.*)/articles/(code/)?([^/]+)/(\d+)(/)?(\d+)?")`
`43`	`43`
`44`	`44`	`def detect(self, doi, ref=None, extra_args=None):`
`45`	`45`	`"""Trigger this provider for things that resolve to a Figshare article"""`