Skip to content

Commit b3de499

Browse files
authored
Merge pull request #1165 from yuvipanda/bump
Bump default R version to 4.2 from 4.1, and let R 3.4 go from 3.4.0 to 3.4.4
2 parents bdec455 + 7e517cf commit b3de499

File tree

3 files changed

+12
-6
lines changed

3 files changed

+12
-6
lines changed

repo2docker/buildpacks/r.py

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -63,19 +63,25 @@ def r_version(self):
6363
Will return the version specified by the user or the current default
6464
version.
6565
"""
66+
# Available versions at https://cran.r-project.org/src/base/
6667
version_map = {
67-
"4.2": "4.2.0",
68+
"4.2": "4.2.1",
6869
"4.1": "4.1.3",
6970
"4.0": "4.0.5",
7071
"3.6": "3.6.3",
7172
"3.5": "3.5.3",
72-
"3.4": "3.4.0",
73+
"3.4": "3.4.4",
7374
"3.3": "3.3.3",
7475
}
7576

7677
# the default if nothing is specified
7778
# Use full version is needed here, so it a valid semver
78-
r_version = version_map["4.1"]
79+
#
80+
# NOTE: When updating this version, also update
81+
# - tests/unit/test_r.py -> test_version_specification
82+
# - tests/r/simple/verify
83+
#
84+
r_version = version_map["4.2"]
7985

8086
if not hasattr(self, "_r_version"):
8187
parts = self.runtime.split("-")

tests/r/simple/verify

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
#!/usr/bin/env Rscript
22
library('testthat')
33

4-
# Fail if version is not 4.1
5-
if (!(version$major == "4" && as.double(version$minor) >= 1 && as.double(version$minor) < 2)) {
4+
# Fail if version is not 4.2
5+
if (!(version$major == "4" && as.double(version$minor) >= 2 && as.double(version$minor) < 3)) {
66
quit("yes", 1)
77
}

tests/unit/test_r.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88

99

1010
@pytest.mark.parametrize(
11-
"runtime_version, expected", [("", "4.1"), ("3.6", "3.6"), ("3.5.1", "3.5")]
11+
"runtime_version, expected", [("", "4.2"), ("3.6", "3.6"), ("3.5.1", "3.5")]
1212
)
1313
def test_version_specification(tmpdir, runtime_version, expected):
1414
tmpdir.chdir()

0 commit comments

Comments
 (0)