Skip to content

Commit bb177b5

Browse files
committed
upgrade to notebook 7
drops classic notebook server, is not really compatible with jupyter-server 2 rename deprecated NotebookApp CLI args to ServerApp
1 parent 388c934 commit bb177b5

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

repo2docker/app.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -662,8 +662,8 @@ def start_container(self):
662662
"notebook",
663663
"--ip=0.0.0.0",
664664
f"--port={container_port}",
665-
f"--NotebookApp.custom_display_url=http://{host_name}:{host_port}",
666-
"--NotebookApp.default_url=/lab",
665+
f"--ServerApp.custom_display_url=http://{host_name}:{host_port}",
666+
"--ServerApp.default_url=/lab",
667667
]
668668
else:
669669
# run_cmd given by user, if port is also given then pass it on

repo2docker/buildpacks/conda/environment.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,4 +10,4 @@ dependencies:
1010
- jupyter_server==2.* # https://github.com/jupyter-server/jupyter_server
1111
- jupyterhub-singleuser==5.* # https://github.com/jupyterhub/jupyterhub
1212
- jupyterlab==4.* # https://github.com/jupyterlab/jupyterlab
13-
- notebook==6.* # https://github.com/jupyter/notebook
13+
- notebook==7.* # https://github.com/jupyter/notebook

0 commit comments

Comments
 (0)