Prefer to use attribute over internal variable

rgaiacs · rgaiacs · commit e413920bd995 · 2025-11-03T16:21:59.000+01:00
diff --git a/repo2docker/app.py b/repo2docker/app.py
@@ -625,7 +625,7 @@ def start_container(self):
                 "notebook",
                 "--ip=0.0.0.0",
                 f"--port={container_port}",
-                f"--ServerApp.custom_display_url=http://{host_name}:{host_port}",
+                f"--ServerApp.custom_display_url=http://{self.hostname}:{self.port}",
                 "--ServerApp.default_url=/lab",
             ]
         else:

Original file line number	Diff line number	Diff line change
`@@ -625,7 +625,7 @@ def start_container(self):`
`625`	`625`	`"notebook",`
`626`	`626`	`"--ip=0.0.0.0",`
`627`	`627`	`f"--port={container_port}",`
`628`		`- f"--ServerApp.custom_display_url=http://{host_name}:{host_port}",`
	`628`	`+ f"--ServerApp.custom_display_url=http://{self.hostname}:{self.port}",`
`629`	`629`	`"--ServerApp.default_url=/lab",`
`630`	`630`	`]`
`631`	`631`	`else:`