Skip to content

Commit e9c2242

Browse files
committed
fix side-effect method name and add fixme note
1 parent 03d673b commit e9c2242

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

repo2docker/buildpacks/conda/__init__.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,8 +43,10 @@ def get_build_env(self):
4343
4444
"""
4545
if not self._nb_environment_file:
46-
# get_build_scripts locates requirements/environment files
47-
self.get_build_scripts()
46+
# get_build_script_files locates requirements/environment files,
47+
# populating the _nb_environment_file attribute and others.
48+
# FIXME: move file detection and initialization of those attributes to its own step?
49+
self.get_build_script_files()
4850

4951
env = super().get_build_env() + [
5052
("CONDA_DIR", "${APP_BASE}/conda"),

0 commit comments

Comments
 (0)