Skip to content

Commit f7118ed

Browse files
authored
Merge pull request #993 from consideRatio/pr/unit-test-24.04
ci: run unit tests in ubuntu-24.04 github actions environment as well
2 parents 73f8833 + b034fc6 commit f7118ed

File tree

2 files changed

+7
-4
lines changed

2 files changed

+7
-4
lines changed

.github/workflows/unit-test.yaml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,9 @@ jobs:
4646
- name: "Ubuntu 22.04, Py 3.10"
4747
ubuntu_version: "22.04"
4848
python_version: "3.10"
49+
- name: "Ubuntu 24.04, Py 3.12"
50+
ubuntu_version: "24.04"
51+
python_version: "3.12"
4952

5053
steps:
5154
- uses: actions/checkout@v4

tests/test_config.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -147,17 +147,17 @@ def test_reload_hub():
147147
"tljh.systemd.check_service_active"
148148
) as check_active, mock.patch("tljh.config.check_hub_ready") as check_ready:
149149
config.reload_component("hub")
150-
assert restart_service.called_with("jupyterhub")
151-
assert check_active.called_with("jupyterhub")
150+
restart_service.assert_called_with("jupyterhub")
151+
check_active.assert_called_with("jupyterhub")
152152

153153

154154
def test_reload_proxy(tljh_dir):
155155
with mock.patch("tljh.systemd.restart_service") as restart_service, mock.patch(
156156
"tljh.systemd.check_service_active"
157157
) as check_active:
158158
config.reload_component("proxy")
159-
assert restart_service.called_with("traefik")
160-
assert check_active.called_with("traefik")
159+
restart_service.assert_called_with("traefik")
160+
check_active.assert_called_with("traefik")
161161
assert os.path.exists(os.path.join(config.STATE_DIR, "traefik.toml"))
162162

163163

0 commit comments

Comments
 (0)