Skip to content

Commit 0e7347d

Browse files
committed
docs: update comments in Dockerfiles to align with binderhub
1 parent 61e1824 commit 0e7347d

File tree

2 files changed

+11
-3
lines changed

2 files changed

+11
-3
lines changed

images/hub/Dockerfile

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,12 +7,16 @@
77
# This stage is building Python wheels for use in later stages by using a base
88
# image that has more pre-requisites to do so, such as a C++ compiler.
99
#
10+
# NOTE: If the image version is updated, also update it in ci/refreeze and
11+
# singleuser-sample's Dockerfile!
12+
#
1013
FROM python:3.11-bullseye as build-stage
1114

1215
# Build wheels
1316
#
1417
# We set pip's cache directory and expose it across build stages via an
15-
# ephemeral docker cache (--mount=type=cache,target=${PIP_CACHE_DIR}).
18+
# ephemeral docker cache (--mount=type=cache,target=${PIP_CACHE_DIR}). We use
19+
# the same technique for the directory /tmp/wheels.
1620
#
1721
COPY requirements.txt requirements.txt
1822
ARG PIP_CACHE_DIR=/tmp/pip-cache
@@ -56,7 +60,7 @@ RUN apt-get update \
5660
tini \
5761
&& rm -rf /var/lib/apt/lists/*
5862

59-
# install wheels built in the build-stage
63+
# install wheels built in the build stage
6064
COPY requirements.txt /tmp/requirements.txt
6165
ARG PIP_CACHE_DIR=/tmp/pip-cache
6266
RUN --mount=type=cache,target=${PIP_CACHE_DIR} \

images/singleuser-sample/Dockerfile

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,12 +7,16 @@
77
# This stage is building Python wheels for use in later stages by using a base
88
# image that has more pre-requisites to do so, such as a C++ compiler.
99
#
10+
# NOTE: If the image version is updated, also update it in ci/refreeze and
11+
# hub's Dockerfile!
12+
#
1013
FROM python:3.11-bullseye as build-stage
1114

1215
# Build wheels
1316
#
1417
# We set pip's cache directory and expose it across build stages via an
15-
# ephemeral docker cache (--mount=type=cache,target=${PIP_CACHE_DIR}).
18+
# ephemeral docker cache (--mount=type=cache,target=${PIP_CACHE_DIR}). We use
19+
# the same technique for the directory /tmp/wheels.
1620
#
1721
COPY requirements.txt requirements.txt
1822
ARG PIP_CACHE_DIR=/tmp/pip-cache

0 commit comments

Comments
 (0)