Skip to content

Commit 1db212d

Browse files
committed
Fix edge case with numerical namespace strings
1 parent 6220819 commit 1db212d

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

jupyterhub/templates/httproute.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ spec:
1414
- kind: Gateway
1515
name: {{ .Values.httpRoute.gateway.name }}
1616
{{- with .Values.httpRoute.gateway.namespace }}
17-
namespace: {{ . }}
17+
namespace: "{{ . }}"
1818
{{- end }}
1919
{{- with .Values.httpRoute.hostnames }}
2020
hostnames:

jupyterhub/values.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -720,7 +720,7 @@ httpRoute:
720720
hostnames: []
721721
gateway:
722722
name: your-gateway
723-
# namespace: if different from Z2JH
723+
namespace: "" # required for a gateway resource in another namespace
724724

725725
# cull relates to the jupyterhub-idle-culler service, responsible for evicting
726726
# inactive singleuser pods.

0 commit comments

Comments
 (0)