Skip to content

Commit 2dd123f

Browse files
minrkconsideRatio
andauthored
Clarify pip cache ARG choice comment
Co-authored-by: Erik Sundell <[email protected]>
1 parent 05319bb commit 2dd123f

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

images/hub/Dockerfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,8 +53,8 @@ RUN apt-get update && \
5353
tini \
5454
&& rm -rf /var/lib/apt/lists/*
5555

56-
# set env for pip cache,
57-
# but use ARG to avoid persisting in image
56+
# set pip's cache directory using this environment variable, and use
57+
# ARG instead of ENV to ensure its only set when the image is built
5858
ARG PIP_CACHE_DIR=/tmp/pip-cache
5959

6060
# install wheels built in the build-stage

images/singleuser-sample/Dockerfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,8 @@ FROM python:3.9-bullseye as build-stage
77

88
WORKDIR /build-stage
99

10-
# set env for pip cache,
11-
# but use ARG to avoid persisting in image
10+
# set pip's cache directory using this environment variable, and use
11+
# ARG instead of ENV to ensure its only set when the image is built
1212
ARG PIP_CACHE_DIR=/tmp/pip-cache
1313

1414
# These are mounted into the final image for installation

0 commit comments

Comments
 (0)