Skip to content

Commit 5b9f7ac

Browse files
committed
Fix implementation of proxy-public Service's selector
1 parent c93be60 commit 5b9f7ac

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

jupyterhub/templates/proxy/service.yaml

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -35,13 +35,15 @@ metadata:
3535
{{- end }}
3636
spec:
3737
selector:
38+
# This service will target the autohttps pod if autohttps is configured, and
39+
# the proxy pod if not. When autohttps is configured, the service proxy-http
40+
# will be around to target the proxy pod directly.
3841
{{- if $autoHTTPS }}
39-
component: autohttps
42+
{{- $_ := merge (dict "componentLabel" "autohttps") . -}}
43+
{{- include "jupyterhub.matchLabels" $_ | nindent 4 }}
4044
{{- else }}
41-
component: proxy
45+
{{- include "jupyterhub.matchLabels" . | nindent 4 }}
4246
{{- end }}
43-
release: {{ .Release.Name }}
44-
app: {{ .appLabel | default (include "jupyterhub.appLabel" .) }}
4547
ports:
4648
{{- if $HTTPS }}
4749
- name: https

0 commit comments

Comments
 (0)