Skip to content

Commit 7e51044

Browse files
authored
Clarify pip cache ARG choice comment (again)
1 parent 3e235cf commit 7e51044

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

images/hub/Dockerfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,8 @@ FROM python:3.9-bullseye as build-stage
77

88
WORKDIR /build-stage
99

10-
# set env for pip cache,
11-
# but use ARG to avoid persisting in image
10+
# set pip's cache directory using this environment variable, and use
11+
# ARG instead of ENV to ensure its only set when the image is built
1212
ARG PIP_CACHE_DIR=/tmp/pip-cache
1313

1414
# Build wheels

images/singleuser-sample/Dockerfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,8 +48,8 @@ RUN apt-get update \
4848
git \
4949
&& rm -rf /var/lib/apt/lists/*
5050

51-
# set env for pip cache,
52-
# but use ARG to avoid persisting in image
51+
# set pip's cache directory using this environment variable, and use
52+
# ARG instead of ENV to ensure its only set when the image is built
5353
ARG PIP_CACHE_DIR=/tmp/pip-cache
5454

5555
# install wheels built in the build-stage

0 commit comments

Comments
 (0)