Skip to content

Commit 82891d3

Browse files
authored
Merge pull request #3683 from holzman/externalIPs
Add `proxy.service.externalIPs` config
2 parents 163be9c + 523b1d2 commit 82891d3

File tree

4 files changed

+14
-0
lines changed

4 files changed

+14
-0
lines changed

jupyterhub/templates/proxy/service.yaml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -81,3 +81,7 @@ spec:
8181
{{- . | toYaml | nindent 4 }}
8282
{{- end }}
8383
{{- end }}
84+
{{- with .Values.proxy.service.externalIPs }}
85+
externalIPs:
86+
{{- . | toYaml | nindent 4 }}
87+
{{- end }}

jupyterhub/values.schema.yaml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1751,6 +1751,12 @@ properties:
17511751
See [the Kubernetes
17521752
documentation](https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.23/#serviceport-v1-core)
17531753
for the structure of the items in this list.
1754+
externalIPs:
1755+
type: array
1756+
description: |
1757+
A list of external IP addresses (unmanaged by Kubernetes) for which
1758+
nodes in the cluster will accept traffic for this service.
1759+
See [externalIPs](https://kubernetes.io/docs/concepts/services-networking/service/#external-ips) for more details.
17541760
loadBalancerIP:
17551761
type: [string, "null"]
17561762
description: |

jupyterhub/values.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -196,6 +196,7 @@ proxy:
196196
https:
197197
disableHttpPort: false
198198
extraPorts: []
199+
externalIPs: []
199200
loadBalancerIP:
200201
loadBalancerSourceRanges: []
201202
# chp relates to the proxy pod, which is responsible for routing traffic based

tools/templates/lint-and-validate-values.yaml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -223,6 +223,9 @@ proxy:
223223
nodePorts:
224224
http:
225225
https:
226+
externalIPs:
227+
- 123.123.123.123
228+
- 123.123.123.124
226229
chp:
227230
revisionHistoryLimit: 1
228231
extraCommandLineFlags:

0 commit comments

Comments
 (0)