Skip to content

Commit 8637cc8

Browse files
authored
Merge pull request #3621 from manics/extraImagesPullPolicy
Add pullPolicy to pre-pulled extraImages
2 parents 6fd45aa + 3984345 commit 8637cc8

File tree

3 files changed

+6
-1
lines changed

3 files changed

+6
-1
lines changed

jupyterhub/templates/image-puller/_helpers-daemonset.tpl

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -196,6 +196,9 @@ spec:
196196
{{- range $k, $v := .Values.prePuller.extraImages }}
197197
- name: image-pull-{{ $k }}
198198
image: {{ $v.name }}:{{ $v.tag }}
199+
{{- with $v.pullPolicy }}
200+
imagePullPolicy: {{ . }}
201+
{{- end }}
199202
command:
200203
- /bin/sh
201204
- -c

jupyterhub/values.schema.yaml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -563,7 +563,7 @@ properties:
563563
v1.11.1
564564
zhy270a
565565
```
566-
pullPolicy:
566+
pullPolicy: &imagePullPolicy
567567
enum: [null, "", IfNotPresent, Always, Never]
568568
description: |
569569
Configures the Pod's `spec.imagePullPolicy`.
@@ -2921,6 +2921,7 @@ properties:
29212921
type: string
29222922
tag:
29232923
type: string
2924+
pullPolicy: *imagePullPolicy
29242925
containerSecurityContext: *containerSecurityContext-spec
29252926
pause:
29262927
type: object

tools/templates/lint-and-validate-values.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -574,6 +574,7 @@ prePuller:
574574
mockImage2:
575575
name: mock-user/mock-image2
576576
tag: mock-tag
577+
pullPolicy: Always
577578

578579
ingress:
579580
enabled: true

0 commit comments

Comments
 (0)