Skip to content

Commit c3e818e

Browse files
committed
fix default pvc mounting with kubespawner 7
- remove unneeded default for pvcNameTemplate - use new `{pvc_name}` template field to mount the spawner's resolved pvc, rather than overriding the claim name, which may not match the created pvc
1 parent 3e200ab commit c3e818e

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

jupyterhub/files/hub/jupyterhub_config.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -256,7 +256,8 @@ def camelCaseify(s):
256256
storage_type = get_config("singleuser.storage.type")
257257
if storage_type == "dynamic":
258258
pvc_name_template = get_config("singleuser.storage.dynamic.pvcNameTemplate")
259-
c.KubeSpawner.pvc_name_template = pvc_name_template
259+
if pvc_name_template:
260+
c.KubeSpawner.pvc_name_template = pvc_name_template
260261
volume_name_template = get_config("singleuser.storage.dynamic.volumeNameTemplate")
261262
c.KubeSpawner.storage_pvc_ensure = True
262263
set_config_if_not_none(
@@ -275,7 +276,7 @@ def camelCaseify(s):
275276
c.KubeSpawner.volumes = [
276277
{
277278
"name": volume_name_template,
278-
"persistentVolumeClaim": {"claimName": pvc_name_template},
279+
"persistentVolumeClaim": {"claimName": "{pvc_name}"},
279280
}
280281
]
281282
c.KubeSpawner.volume_mounts = [

jupyterhub/values.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -413,8 +413,8 @@ singleuser:
413413
homeMountPath: /home/jovyan
414414
dynamic:
415415
storageClass:
416-
pvcNameTemplate: claim-{username}{servername}
417-
volumeNameTemplate: volume-{username}{servername}
416+
pvcNameTemplate:
417+
volumeNameTemplate: volume-{user_server}
418418
storageAccessModes: [ReadWriteOnce]
419419
subPath:
420420
image:

0 commit comments

Comments
 (0)