Skip to content

Conversation

@manics
Copy link
Member

@manics manics commented Nov 9, 2024

  • claim_groups_key is deprecated, replaced by auth_state_groups_key
  • manage_groups must be used with the above, otherwise JupyterHub fails to start

@consideRatio
Copy link
Member

To fix these docs are an improvement and happy to merge it, but an alternative improvement would be to delete them from z2jh and link to docs like this in oauthenticator instead. I figure that project benefits from a well maintained keycloak example, but that its hard to maintain it in z2jh/tljh/oauthenticator

Copy link
Member

@consideRatio consideRatio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whats in the PR looks fine currently, since this is docs only and what we currently have is broken, i figure momentum is more important than deep scrutiny so approving already even though its in draft

@manics
Copy link
Member Author

manics commented Nov 12, 2024

We could make this a very minimal Keycloak example, I've got a CI tested example in https://github.com/manics/zero-to-jupyterhub-k8s-examples/tree/main/keycloak

It's too complicated, as it requires corresponding Keycloak configuration
@manics
Copy link
Member Author

manics commented Nov 13, 2024

I decided to take out managed groups/roles completely, as it's not very useful unless you also configure Keycloak.

@manics manics marked this pull request as ready for review November 13, 2024 18:39
@minrk minrk merged commit a9b1ca4 into jupyterhub:main Nov 19, 2024
3 checks passed
@manics manics deleted the keycloak-config branch November 19, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants