Skip to content

Commit ecaec67

Browse files
committed
Fix dev env
...
1 parent db41ea3 commit ecaec67

File tree

4 files changed

+6
-3
lines changed

4 files changed

+6
-3
lines changed

.dockerignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
node_modules/

Taskfile.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ tasks:
1313
desc: Build docker image for dev
1414
cmds:
1515
- docker compose -f docker-compose.dev.yml build
16-
- docker exec -it jupyterlab_code_formatter-dev-1 jlpm install
1716

1817
dev:up:
1918
desc: Spin up the docker compose stack for dev
@@ -23,7 +22,7 @@ tasks:
2322
dev:down:
2423
desc: Shut down the docker compose stack for dev
2524
cmds:
26-
- docker compose -f docker-compose.dev.yml up
25+
- docker compose -f docker-compose.dev.yml down
2726

2827
dev:jlpm-watch:
2928
desc: Run `jlpm watch` task inside the dev container.

dev.Dockerfile

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,5 +65,4 @@ RUN --mount=type=cache,target=/root/.cache/pip \
6565
pip install -e ".[test]"
6666
RUN jupyter labextension develop . --overwrite
6767
RUN jupyter server extension enable jupyterlab_code_formatter
68-
RUN jlpm install
6968
RUN jlpm build

docker-compose.dev.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,4 +9,8 @@ services:
99
network_mode: host # Can't be bother to expose a bunch of ports.
1010
volumes:
1111
- ./:/plugin
12+
- node_modules:/plugin/node_modules
1213
entrypoint: sleep 99d
14+
15+
volumes:
16+
node_modules:

0 commit comments

Comments
 (0)