Localization for signals example

Author: thegooman

basics/signals/package.json

@@ -45,6 +45,7 @@
     "@jupyterlab/application": "~3.0.0-beta.4",
     "@jupyterlab/launcher": "~3.0.0-beta.4",
     "@jupyterlab/mainmenu": "~3.0.0-beta.4",
+    "@jupyterlab/translation": "^3.0.0-beta.4",
     "@lumino/algorithm": "^1.3.3",
     "@lumino/coreutils": "^1.5.3",
     "@lumino/datagrid": "^0.3.1",

basics/signals/src/index.ts

@@ -9,6 +9,8 @@ import { ILauncher } from '@jupyterlab/launcher';
 
 import { IMainMenu } from '@jupyterlab/mainmenu';
 
+import { ITranslator } from '@jupyterlab/translation';
+
 import { Menu } from '@lumino/widgets';
 
 import { SignalExamplePanel } from './panel';
@@ -27,7 +29,7 @@ const extension: JupyterFrontEndPlugin<void> = {
   id: 'signals',
   autoStart: true,
   optional: [ILauncher],
-  requires: [ICommandPalette, IMainMenu],
+  requires: [ICommandPalette, IMainMenu, ITranslator],
   activate: activate
 };
 
@@ -43,11 +45,13 @@ function activate(
   app: JupyterFrontEnd,
   palette: ICommandPalette,
   mainMenu: IMainMenu,
-  launcher: ILauncher | null
+  launcher: ILauncher | null,
+  translator: ITranslator
 ): void {
   const manager = app.serviceManager;
   const { commands, shell } = app;
   const category = 'Extension Examples';
+  const trans = translator.load('jupyterlab');
 
   // Add launcher
   if (launcher) {
@@ -65,21 +69,21 @@ function activate(
   function createPanel(): Promise<SignalExamplePanel> {
     let panel: SignalExamplePanel;
     return manager.ready.then(() => {
-      panel = new SignalExamplePanel();
+      panel = new SignalExamplePanel(translator);
       shell.add(panel, 'main');
       return panel;
     });
   }
 
   // Add menu tab
   const signalMenu = new Menu({ commands });
-  signalMenu.title.label = 'Signal Example';
+  signalMenu.title.label = trans.__('Signal Example');
   mainMenu.addMenu(signalMenu);
 
   // Add commands to registry
   commands.addCommand(CommandIDs.create, {
-    label: 'Open the Signal Example Panel',
-    caption: 'Open the Signal Example Panel',
+    label: trans.__('Open the Signal Example Panel'),
+    caption: trans.__('Open the Signal Example Panel'),
     execute: createPanel
   });
 

basics/signals/src/panel.ts

@@ -1,3 +1,8 @@
+import {
+  ITranslator,
+  nullTranslator,
+  TranslationBundle
+} from '@jupyterlab/translation';
 import { StackedPanel } from '@lumino/widgets';
 
 import { ButtonWidget, ICount } from './button';
@@ -10,11 +15,13 @@ const PANEL_CLASS = 'jp-tutorial-view';
  * A panel which contains a console and the ability to add other children.
  */
 export class SignalExamplePanel extends StackedPanel {
-  constructor() {
+  constructor(translator?: ITranslator) {
     super();
+    this._translator = translator || nullTranslator;
+    this._trans = this._translator.load('jupyterlab');
     this.addClass(PANEL_CLASS);
     this.id = 'SignalExamplePanel';
-    this.title.label = 'Signal Example View';
+    this.title.label = this._trans.__('Signal Example View');
     this.title.closable = true;
 
     this._widget = new ButtonWidget();
@@ -33,4 +40,7 @@ export class SignalExamplePanel extends StackedPanel {
   }
 
   private _widget: ButtonWidget;
+
+  private _translator: ITranslator;
+  private _trans: TranslationBundle;
 }